Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo publishing #50

Closed
fenollp opened this issue Jan 9, 2017 · 2 comments
Closed

cargo publishing #50

fenollp opened this issue Jan 9, 2017 · 2 comments

Comments

@fenollp
Copy link
Contributor

fenollp commented Jan 9, 2017

It'd be nice to also have the crate pushed to crates.io, on tagged commits, after tests passed.

Seems rather easy to implement: https://github.com/tomaka/glutin/blob/a974631197da6da9d9a91b00b4bfc75345608e51/.travis.yml#L31

@japaric
Copy link
Owner

japaric commented Jan 9, 2017

I'm not 100% sure about this. In the past, I had commited what would have been e.g. v0.1.1 and tried to cargo publish that but it failed due to metadata issues (e.g. too many keywords). Had I pushed that tag to let CI handle it, CI would have failed to publish it too and I would have ended with a GitHub tag but no published crate ...

That's why I always do my releases like this:

$ git commit -m 'release v0.1.1`
$ cargo publish  # if this fails, fix the problem and amend the last commit
$ git tag -a v0.1.1  # we are sure that a crate was published!
$ git push
$ git push origin v0.1.1

@fenollp
Copy link
Contributor Author

fenollp commented Jan 9, 2017

Works for me :)

@fenollp fenollp closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants