Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is --target passed when it's already the default toolchain? #88

Open
faern opened this issue Oct 13, 2017 · 0 comments
Open

Why is --target passed when it's already the default toolchain? #88

faern opened this issue Oct 13, 2017 · 0 comments

Comments

@faern
Copy link
Contributor

faern commented Oct 13, 2017

Both the Travis-CI and AppVeyor configs pass --target $TARGET/--target %TARGET% flags to cargo when building and testing. Why is this? Would it make any difference if they were removed?
At least for AppVeyor the host in the %TARGET% variable has already been configured as the default in:

- rustup-init.exe -y --default-host %TARGET% --default-toolchain %RUST_VERSION%

The reason I ask is because of this bug: rust-lang/cargo#4254
Which stops me from using the serde features = ["derive"] trick on stable Rust on Windows. So I'm thinking to remove --target from my appveyor.yml. It seems to work, just want to check if there are any factors I miss.

@faern faern changed the title Why is --target passed when it's already the default toolchain? Why is --target passed when it's already the default toolchain? Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant