Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDefaults ? #15

Closed
chandu0101 opened this issue Mar 24, 2015 · 1 comment
Closed

ReactDefaults ? #15

chandu0101 opened this issue Mar 24, 2015 · 1 comment

Comments

@chandu0101
Copy link

Current Defaults trait full fills general needs , what about ReactDefaults which contains react specific helpers .

trait ReactDefaults extends Defaults {

  implicit override def register: Register = ???

}

its good to have register which will prefix class names with react component name , at this moment i am not sure weather its possible or not!

@japgolly
Copy link
Owner

I considered making a ReactDefaults but realised there was nothing in the defaults that needed changing.

Prefixing class names with the React component name is... I don't see how that's possible. In order to make that possible we would need to address the larger problem of best practices for styled generic components. How to solve that is unclear at this point. It would be best for us all to explore our own ideas in our different codebases and share experiences in, say, 2 months or so.

I'll close this for now; we can reopen in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants