Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG <.marker doesn't support orient, refX, and refY? #471

Closed
IanOlin opened this issue Jun 22, 2018 · 5 comments
Closed

SVG <.marker doesn't support orient, refX, and refY? #471

IanOlin opened this issue Jun 22, 2018 · 5 comments

Comments

@IanOlin
Copy link

IanOlin commented Jun 22, 2018

This might be an issue on how I'm using it, but I can't seem to set the references and orientation on markers. Is this not supported yet or have I done something wrong?

@IanOlin
Copy link
Author

IanOlin commented Jun 22, 2018

Resolved by using custom VdomAttrs. I'm going to leave the issue open in case this is actually a bug, feel free to close it if there's no plans to support these features though (or if they are supported and I'm just not seeing it).

@japgolly
Copy link
Owner

Hi @IanOlin, glad to hear you got it working. Could you share the custom VdomAttrs that you created? If there's something wrong with scalajs-react I'd definitely like to fix it.

@IanOlin
Copy link
Author

IanOlin commented Jun 28, 2018

Hi @japgolly , sorry about the delay. Here's the custom VdomAttrs:

val orient = VdomAttr("orient")
val refX = VdomAttr("refX")
val refY = VdomAttr("refY")

@japgolly
Copy link
Owner

Oh I misunderstood the issue. The issue is that these attributes aren't included in scalajs-react? Ok that's an easy fix!

Closed via d76f279

@japgolly
Copy link
Owner

These attributes will be available out-of-the-box in the next release. If you encounter any more missing feel free to send a PR using the above commit as a guide. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants