Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate logic for handling prepositional phrases separated by dashes and spaces. #153

Merged
merged 2 commits into from May 1, 2022

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented May 1, 2022

No description provided.

@jaraco
Copy link
Owner Author

jaraco commented May 1, 2022

This change reduces the mccabe complexity for _plnoun and _sinoun by 3 and 8 respectively:

inflect main $ .tox/python/bin/python -m mccabe inflect/__init__.py | grep _..noun
2638:4: 'engine._plnoun' 91
3078:4: 'engine._sinoun' 100
inflect main $ git checkout refactor/prepositional-phrase-handler
Switched to branch 'refactor/prepositional-phrase-handler'
Your branch is up to date with 'origin/refactor/prepositional-phrase-handler'.
inflect refactor/prepositional-phrase-handler $ .tox/python/bin/python -m mccabe inflect/__init__.py | grep _..noun
2640:4: 'engine._plnoun' 88
3110:4: 'engine._sinoun' 92

@jaraco jaraco merged commit 26ed75c into main May 1, 2022
@jaraco jaraco deleted the refactor/prepositional-phrase-handler branch May 1, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant