Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIO] Connection real_nickname must not be set before registration #190

Open
hifi opened this issue Jun 10, 2021 · 1 comment
Open

[AIO] Connection real_nickname must not be set before registration #190

hifi opened this issue Jun 10, 2021 · 1 comment

Comments

@hifi
Copy link

hifi commented Jun 10, 2021

Some networks (IRCnet in particular) may reserve nicknames temporarily when you disconnect. The network will send 437 ERR_UNAVAILRESOURCE during connection registration which means our real real nickname is not yet actually set.

Having it an empty string or None would help detecting this issue during registration that our desired nickname is not available right now and the downstream implementation can decide what to do with this information, like use a temporary nickname and a timer to retry the real nickname later.

Without any subclassing, currently it is required to wait for 001 before believing real_nickname which will add unnecessary complexity.

@hifi hifi changed the title Connection real_nickname must not be set before registration [AIO] Connection real_nickname must not be set before registration Jun 10, 2021
@hifi
Copy link
Author

hifi commented Jun 10, 2021

Depends on #189 to be useful at pre-registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant