two helpers for rails consistently #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbeck
requested changes
Feb 22, 2018
lib/paper_trail/sinatra.rb
Outdated
| private | ||
|
|
||
| # Tells PaperTrail who is responsible for any changes that occur. | ||
| def set_paper_trail_whodunnit | ||
| @set_paper_trail_whodunnit_called = true | ||
| ::PaperTrail.whodunnit = user_for_paper_trail if ::PaperTrail.enabled? | ||
| end | ||
|
|
||
| def set_paper_trail_request_info | ||
| @set_paper_trail_request_info_called = true |
There was a problem hiding this comment.
I don't think this instance variable is necessary. You were probably copying @set_paper_trail_whodunnit_called above. It, also, is not necessary. I think it was copied to this repository by mistake.
spec/modular_sinatra_spec.rb
Outdated
| widget2 = Widget.last | ||
| expect(widget2).to_not be_nil | ||
| expect(widget2.name).to eq("foo") | ||
| expect(widget2.versions.size).to eq(0) |
There was a problem hiding this comment.
Why test get "/test" twice? Could this be two separate it examples?
lib/paper_trail/sinatra.rb
Outdated
|
|
||
| def paper_trail_enabled_for_request | ||
| ::PaperTrail.enabled? | ||
| end |
There was a problem hiding this comment.
Please add documentation for both of these methods. You can copy the documentation from paper_trail/frameworks/rails/controller.rb
CI is set up. Please also add an entry to the changelog under Unreleased -> Added. Thanks! |
jaredbeck
approved these changes
Feb 22, 2018
|
Thanks @devvit. Will release as 0.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller_infoandenabled_for_controllerare available,but sinatra has not controller,
paper_trail_enabled_for_controllernamed topaper_trail_enabled_for_request