Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This client violates the RFC for openid #117

Open
hcldan opened this issue Oct 10, 2019 · 3 comments
Open

This client violates the RFC for openid #117

hcldan opened this issue Oct 10, 2019 · 3 comments

Comments

@hcldan
Copy link

hcldan commented Oct 10, 2019

Greetings!

We recently got a support ticket from a customer who is using your passport oauth2 module.
They are having an issue with client authentication. The issue does not occur when using other standards-compliant modules to do oauth2 flows.

We use https://github.com/panva/node-oidc-provider an OpenID certified project as our server.
I believe the issue we are running into is this: https://github.com/panva/node-oidc-provider/issues/361

The problem is that the spec is not being followed in the passport-oauth2 module.
Could you look into this? Is this something you are willing to fix?
This issue may be related: #106

Thanks!

@jaredhanson
Copy link
Owner

jaredhanson commented Oct 10, 2019 via email

@hcldan
Copy link
Author

hcldan commented Oct 11, 2019 via email

@hcldan
Copy link
Author

hcldan commented Oct 11, 2019

Actually... taking a look at that project, you may want to consider moving away. Last commit was 2017.
There are tons of open issues, and it appears to be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants