Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add fuels for the Railcraft Blast Furnace #193

Closed
SynfulChaot opened this issue Jul 17, 2015 · 20 comments
Closed

[Request] Add fuels for the Railcraft Blast Furnace #193

SynfulChaot opened this issue Jul 17, 2015 · 20 comments

Comments

@SynfulChaot
Copy link

Would it be possible to create a handler for adding new fuels to the Railcraft Blast Furnace?

@Zixxl
Copy link
Contributor

Zixxl commented Jul 17, 2015

It would be possible to add / remove items to the filter (accepted items) but you can't specify the fuel value for the items.

@SynfulChaot
Copy link
Author

I know that current fuels in the Blast Furnace have differing fuel values. Perhaps it uses the default value of the fuel itself?

@Zixxl
Copy link
Contributor

Zixxl commented Jul 17, 2015

The blast furnace uses some hard coded fuel values for coal coke, blaze rods and so on. If it doesn't know the fuel value, it will retrieve the value from the vanilla furnace.
So if you want adding new fuels to the railcraft blast furnace, you have to add a valid fuel source for the vanilla furnace and then add this item to the item filter for accepted items.
We could add a handler to manipulate the filter.

@Yulife
Copy link
Collaborator

Yulife commented Jul 17, 2015

Well, it would be possible to edit the vanilla fuel value Railcraft wants to grab. How would you imagine the manipulation @Zixxl?

@Voidi
Copy link
Contributor

Voidi commented Jul 17, 2015

I original thougt the same way as zixxl that Tailcraft uses vanilla furnace fuel list.
But looking at https://github.com/CovertJaguar/Railcraft/blob/master/src/main/java/mods/railcraft/common/util/crafting/BlastFurnaceCraftingManager.java#L37 it seems the build an own list.
Shouldn't that complicated to modify.

@Zixxl
Copy link
Contributor

Zixxl commented Jul 17, 2015

Seems like the Railcraft lib in the modtweaker repository is outdated. If it includes a list in newer versions, we could add a handler.

@Zixxl Zixxl mentioned this issue Jul 20, 2015
9 tasks
@Zixxl
Copy link
Contributor

Zixxl commented Jul 20, 2015

fuels = Collections.unmodifiableList(fuel);
Someone really wants to prevent modifications 😞

@Dream-Master
Copy link

So it will be possible or not to set new Fuels with the newest Version?

@Zixxl
Copy link
Contributor

Zixxl commented Jul 20, 2015

Kind of. I've added the handlers to my dev branch. But you can only modify the filter, it must be a valid fuel item known by the vanilla furnace.

@SynfulChaot
Copy link
Author

So it can be added to but it's limited to anything that's registered as a fuel for vanilla furnaces?

@Zixxl
Copy link
Contributor

Zixxl commented Jul 20, 2015

Exactly, you can burn your sticks for example or remove coal coke as a valid input.
If you want to add custom fuels, you have to register it first with MineTweaker as a vanilla fuel. E.g. you want to use redstone, you can use:
furnace.setFuel(<minecraft:redstone>, 100);

@UndeadZeratul
Copy link

How breaking would it be to register an item as a vanilla fuel, then add it to the furnace, then remove the item as a vanilla fuel?

I'm going to assume Railcraft won't know what to do with the item anymore since it's no longer a fuel, but it was registered as one at the time of being enabled as a furnace fuel.

@Zixxl
Copy link
Contributor

Zixxl commented Jul 20, 2015

Sadly doesn't work this way. Railcraft has a list with all the items which can be used as an input. This list can be modified with the changes. But the fuel value will be fetched everytime the fuel will be used. Your method will lead to an exception.

@UndeadZeratul
Copy link

Darn, I was afraid of that.

@SynfulChaot
Copy link
Author

Cool! That's functionality enough, I think. After all, what would be used in a blast furnace as fuel that wouldn't be burnable everywhere else?

@Yulife
Copy link
Collaborator

Yulife commented Sep 24, 2015

@Zixxl this doesn't seem to work very well - it just churns through the fuel in a matter of seconds although I set the burn time to 4000000. Proof

@Tsyklop
Copy link

Tsyklop commented Sep 26, 2015

http://pastebin.com/GmYUjSwa

my Error

@Yulife
Copy link
Collaborator

Yulife commented Sep 26, 2015

With error I meant that you should post your script, MT log and a description of the issue.

@Voidi Voidi closed this as completed Oct 7, 2015
@Tsyklop
Copy link

Tsyklop commented Oct 7, 2015

@Yulife Fixed?

@Voidi
Copy link
Contributor

Voidi commented Oct 7, 2015

Please test it.
Works for me with Railcraft 9.7.0, Modtweaker latest git version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants