You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current Maven publishing configuration has a few issues and will require some changes to work with a multiproject setup. It looks like you've fixed most of these in your Clumps implementation but I would like to see some of these changes backported here.
Common Artifacts
The Common artifacts are not published currently. While normal Forge and Fabric mods can still use MultiLoader projects without the Common artifacts other MultiLoader projects would greatly benefit from having them available. For example imagine writing a CraftTweaker addon in a MultiLoader project. It would make sense for this addon to define new ZenCode natives in the Common project. The same would be true for a GameStage or WAILA addon.
Inconsistent Artifact Coordinates
The artifact coordinates for the Forge and Fabric artifacts are not consistent. The version number also differs between version and structure. There would be a lot to gain from standardizing this, especially now that we publish so many artifacts and other MultiLoader projects will be defining them three times. One benefit would be that it becomes easier to share coordinates with others, and make it easier to locate when traversing the maven manually. This will also aid in creating 3rd party tools or helpers to lookup artifacts. For example a helper method that accepts a group, project name, and version and will automatically create dependencies using the template "${group}:${name}-${platform}-${mc_version}:${version}" in the correct subprojects.
My proposed changes would include the following.
Group keeps the same structure. If there were any loader-specific references here they should be removed.
Name should be suffixed with the platform name (forge/fabric/common) and include the game version.
Version should continue on from the highest major version. So if Forge is 1.0.2 and Fabric is 8.0.12 the next joint release should become 9.0.13 for both.
The current Maven publishing configuration has a few issues and will require some changes to work with a multiproject setup. It looks like you've fixed most of these in your Clumps implementation but I would like to see some of these changes backported here.
Common Artifacts
The Common artifacts are not published currently. While normal Forge and Fabric mods can still use MultiLoader projects without the Common artifacts other MultiLoader projects would greatly benefit from having them available. For example imagine writing a CraftTweaker addon in a MultiLoader project. It would make sense for this addon to define new ZenCode natives in the Common project. The same would be true for a GameStage or WAILA addon.
Inconsistent Artifact Coordinates
The artifact coordinates for the Forge and Fabric artifacts are not consistent. The version number also differs between version and structure. There would be a lot to gain from standardizing this, especially now that we publish so many artifacts and other MultiLoader projects will be defining them three times. One benefit would be that it becomes easier to share coordinates with others, and make it easier to locate when traversing the maven manually. This will also aid in creating 3rd party tools or helpers to lookup artifacts. For example a helper method that accepts a group, project name, and version and will automatically create dependencies using the template
"${group}:${name}-${platform}-${mc_version}:${version}"
in the correct subprojects.My proposed changes would include the following.
Old Artifact Coordinates
New Artifact Coordinates
Misc Improvements
The text was updated successfully, but these errors were encountered: