Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expect-should-assertion rule #12

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

jaredmcateer
Copy link
Owner

Adds rule the checks if the Should.js function variable is being called without an assertion

e.g.,

should(false); // Test will falsely report success (but no assertions)

@github-actions
Copy link
Contributor

Lines Statements Branches Functions
Coverage: 100%
93.02% (80/86) 100% (16/16) 78.78% (78/99)

@jaredmcateer jaredmcateer merged commit bcf714a into main Apr 12, 2022
@jaredmcateer jaredmcateer deleted the no-should-assertions branch April 12, 2022 03:05
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant