Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: HttpClient #33

Closed
rowellx68 opened this issue Mar 7, 2016 · 1 comment
Closed

Question: HttpClient #33

rowellx68 opened this issue Mar 7, 2016 · 1 comment

Comments

@rowellx68
Copy link
Contributor

Is there a particular reason as to why the HttpClient still resolve's if the error status is 404?

I have noticed that the starter project will just be stuck at Loading... if the slug is incorrect. Wouldn't it be better if all errors are rejected so the reducers can deal with it?
@jaredpalmer
Copy link
Owner

Yup. Feel free to submit a PR.

@jaredpalmer jaredpalmer mentioned this issue Jun 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredpalmer @rowellx68