New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media component only works when passing children prop rather than render prop #63
Comments
I was curious about this and could reproduce it on CodeSandbox: |
From my understanding this is actually expected behavior, directly form the
In the example from this issue, we are matching the |
Please update the example in the docs as shown by @morsdyce. I've lost 10 mins on investigating why this doesn't work as expected. |
Consider using |
@Gabri3l the library doesn't work as intended, correct? I'd rather this moves to a breaking change. |
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
Closed due to inactivity. Holler if this is a mistake, and we'll re-open it. |
The following does not work:
but this does:
The text was updated successfully, but these errors were encountered: