Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"set shellcmdflag" and "set shell" doesn't work as expected. #1346

Merged
merged 3 commits into from Apr 23, 2014
Merged

"set shellcmdflag" and "set shell" doesn't work as expected. #1346

merged 3 commits into from Apr 23, 2014

Conversation

idealist1508
Copy link
Contributor

It is impossible to set other shell from Directory with a space in Path
set shell=c:\s\ s\sh.exe
or
set shell="c:\s s\sh.exe"
does't work.

It is also impossible to set more than one flag or flags with a -
set shellcmdflag=-lic

I wrote some integration test, but i can't fix all of them.
Could you look at that, please.

I also set a reference to xunit.extensions. This was needed for a Theory. (Data Driven Test)

idealist1508 added 2 commits April 2, 2014 11:40
- New Tests for shell and shellcmdflag
- Fix for some issues

Conflicts:
	Test/VimCoreTest/VimIntegrationTest.cs
@@ -222,6 +226,9 @@
<ItemGroup>
<None Include="packages.config" />
</ItemGroup>
<ItemGroup>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted

jaredpar added a commit that referenced this pull request Apr 23, 2014
"set shellcmdflag" and "set shell" doesn't work as expected.
@jaredpar jaredpar merged commit 5a27c54 into VsVim:master Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants