Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Logic and Styles #72

Closed
nojacko opened this issue Jan 4, 2016 · 3 comments
Closed

Separate Logic and Styles #72

nojacko opened this issue Jan 4, 2016 · 3 comments

Comments

@nojacko
Copy link

nojacko commented Jan 4, 2016

This is a nice library but it really suffers when customising. For example, rather than a background colour, I'd like to add bottom border (different colour for each type of alert). This isn't possible without modifying the code. This will make updates painful.

I'd recommending removing all the settings variables and creating a default CSS file. The code would just need to change classes of the dom elements based on the status. i.e. To show an alert the CSS would have a class (maybe) classed "notie-show" which would have the CSS animation and this class would be added to the notification container. Also, each alert style should have it's own class. etc...

resizeListener could also be replaced with media queries.

This gives far more flexibility and easier upgrades

@raphaelparent
Copy link

👍

This would also minimize the cluster created when inspecting elements (all the inline style).

And when updating with NPM (or any other package manager like bower), all modifications would be erased.

@jaredreich
Copy link
Owner

Ok thanks guys. Sorry for no updates lately I'm out of the country. Updates will come soon.

@fabiocaccamo
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants