Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make grid calculation not force square crosswords #17

Closed
rhoffmann opened this issue Mar 23, 2020 · 7 comments
Closed

make grid calculation not force square crosswords #17

rhoffmann opened this issue Mar 23, 2020 · 7 comments
Labels
enhancement New feature or request released

Comments

@rhoffmann
Copy link

it would be preferrable to change the grid calculation to allow wide or narrow puzzles.

i am currently working on this in my fork, if i get npm link to work :)
@JaredReisinger
Copy link
Owner

Awesome! I look forward to seeing it!

@JaredReisinger JaredReisinger added the enhancement New feature or request label Mar 27, 2020
@otacke
Copy link

otacke commented Aug 24, 2020

@rhoffmann I'd love to see that, too ;-)

@rhoffmann
Copy link
Author

going to give it a go again in the near future (next weeks hopefully). life happened :)

@snyk-bot snyk-bot mentioned this issue Oct 12, 2020
Closed
@mikedotexe
Copy link

Great idea! Seems like a good place to start is the util.js file's createGridData function. Might give it a go as well at some point.

@AncientSwordRage AncientSwordRage mentioned this issue Oct 21, 2022
Closed
github-actions bot pushed a commit that referenced this issue Dec 13, 2022
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
7a8e4b7 
# [5.1.0](v5.0.0...v5.1.0) (2022-12-13)

### Bug Fixes

* check answer correctness when loading/reloading guesses ([40b9cd5](40b9cd5)), closes [#271](#271)

### Features

* allow non-square rendering ([74a608e](74a608e)), closes [#17](#17)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JaredReisinger
Copy link
Owner

Note that by default, <Crossword> will generate a square puzzle. You need to set the theme.allowNonSquare option to trigger the new non-square rendering behavior.

@JaredReisinger
Copy link
Owner

You can see an example in the documentation.

JaredReisinger pushed a commit that referenced this issue Dec 16, 2022
@semantic-release-bot @JaredReisinger
chore(release): 5.1.0 [skip ci]
e1a12b0 
# [5.1.0](v5.0.0...v5.1.0) (2022-12-13)

### Bug Fixes

* check answer correctness when loading/reloading guesses ([40b9cd5](40b9cd5)), closes [#271](#271)

### Features

* allow non-square rendering ([74a608e](74a608e)), closes [#17](#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhoffmann @mikedotexe @JaredReisinger @otacke