Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache error fallback (bis) #588

Closed
MathieuGuillet opened this issue Sep 8, 2023 · 2 comments
Closed

Cache error fallback (bis) #588

MathieuGuillet opened this issue Sep 8, 2023 · 2 comments

Comments

@MathieuGuillet
Copy link

Hello 馃憢 !
This subject has already been talked about in this issue :

If the call to the cache store fails. Should it fall back to the wrapped function?

We are facing the same issue/requirement using the cache.wrap(...) function : if a call to a multi-cache store fails (in-memory + redis), let's say because Redis is unreachable, then we would expect the cache-manager to call the wrapped function instead of raising an error.

Shouldn't the cache act as a performance optional path to get data, but not interfere to get this data if it is facing errors ?

There used to be a ignoreCacheErrors flag to activate this behavior, but it has been removed in the 5.0.0 version.
Is it possible to reintroduce it ?

Thanks 馃檶

@jaredwray
Copy link
Owner

Hi @MathieuGuillet - we are working on this issue with Keyv version 5 as it should not cause a failure and will use the same code to fix this module. This might take about 60 days to resolve. Just FYI

@slukes
Copy link
Contributor

slukes commented Oct 17, 2023

Hello @jaredwray do you have an issue to follow to know when it is good?

This was referenced Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants