Process#stop does not kill process tree

[jarib]

require 'childprocess'

File.open("test.bat", "w") do |io|
  io << '@ruby -e sleep'
end

proc = ChildProcess.build("test.bat")
proc.io.inherit!
proc.start

sleep 3

proc.stop

puts `tasklist`.split("\n").grep(/ruby/)

[jarib]

But should it? Doesn't happen on Unix either:

require 'childprocess'
require 'fileutils'

File.open("test.sh", "w") do |io|
  io << "#/bin/bash\nruby -e sleep"
end

FileUtils.chmod 0755, 'test.sh'

proc = ChildProcess.build('./test.sh')
proc.io.inherit!
proc.start

sleep 3

proc.stop
puts `ps auxww | grep sleep`

[jarib]

That was simple enough to solve for Unix (now in the kill-process-tree branch), but not sure it's going to be this easy on Windows or Unix+JRuby.

[jarib]

This should be fixed now for all platforms, and I've pushed v4.1.0.rc1 which includes the changes.

The only problem is JRuby + ProcessBuilder, which is currently ChildProcess' weapon of choice on Unix. However, it looks like the latest JRuby (at least 1.7.9) now works well with posix_spawn, so JRuby users have the option to enable that with ChildProcess.posix_spawn = true. We should probably make that the default at some point.

I'm also not completely confident about the implications of this change, so will do some more testing before pushing a real release.