Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseLatestVersions ignores include- and exclude-fitlers #16

Closed
jarmoniuk opened this issue Nov 4, 2022 · 3 comments
Closed

UseLatestVersions ignores include- and exclude-fitlers #16

jarmoniuk opened this issue Nov 4, 2022 · 3 comments

Comments

@jarmoniuk
Copy link
Owner

jarmoniuk commented Nov 4, 2022

I've noticed that the inclusion and exclusion of the include- and exclude-filters in UseLatestVersions. To be verified if it's really not effective and fixed.

If verified -- an issue to be created in the upstream project.

Also, I've noticed that UseLatestVersions is an almost exact copy of UseLatestReleases. There's unnecessary code duplication -- to be abstracted or delegated.

Ideally, the two items could be combined into one since there's almost no difference between the two mojos.

@jarmoniuk
Copy link
Owner Author

It is handled included in line 187 (method isIncluded):

  Artifact artifact = this.toArtifact( dep );
  if ( !isIncluded( artifact ) )
  {
      continue;
  }

@jarmoniuk
Copy link
Owner Author

jarmoniuk commented Nov 4, 2022

TODO: Check if target updates are covered by the above method.

@jarmoniuk
Copy link
Owner Author

Does not ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant