New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractVersionDetails.getLowerBound has the 1-off problem #5

Closed

jarmoniuk opened this issue Sep 1, 2022 · 0 comments

Assignees

Owner

jarmoniuk commented Sep 1, 2022

segment appears to be 0-based

However, the method in the description appears to have the 1-off problem:

protected String getLowerBound( ArtifactVersion version, int segment )
    {
        if ( segment < 0 )
        {
            return null;
        }

        int segmentCount = getVersionComparator().getSegmentCount( version );
        if ( segment > segmentCount )
        {
            throw new InvalidSegmentException( segment, segmentCount,
                    version.toString() );
        }

jarmoniuk mentioned this issue

allowMajorUpdates, allowMinorUpdates, and allowIncrementalUpdates are not independent #4

Closed

jarmoniuk self-assigned this

jarmoniuk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment