Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code partially broken after latest release #4

Closed
gbiavati opened this issue Jun 28, 2021 · 2 comments
Closed

Code partially broken after latest release #4

gbiavati opened this issue Jun 28, 2021 · 2 comments
Assignees
Labels

Comments

@gbiavati
Copy link

Dear Jarodiv,

Thanks for the great Job you are doing in maintaining this puppet module.
Recently you added a parameter $install_options which is declared within an if statement.

Unfortunately the parameter is used also in case the if $facts['os']['release']['major'] == '8' is false.
Or in general in case of '7' the module does not work any longer because $install_options is not defined.

I hope this is enough for you to set a fix.
Currently I am using r10k and to have the module working I set:

mod 'jarodiv-ffmpeg', :git => 'https://github.com/jarodiv/puppet-ffmpeg.git', :commit => '2055c6e'

@Jarodiv
Copy link
Owner

Jarodiv commented Jul 1, 2021

Thanks for the report. I too found the issue when adding rspec tests.

Unfortunately the code doesn't work anymore anyway due to a recent update of the repository I am using (getting tons of missing dependencies now).

I'll soon create a new release, fixing the $install_options issue and also switching to a different repository ('rpmfusion-free'). Only drawback is, that the new repo only offers an older version of ffmpeg (v4.2.3 compared to 4.3.2 in 'epel-multimedia')

@Jarodiv Jarodiv self-assigned this Jul 1, 2021
@Jarodiv Jarodiv added the bug label Jul 1, 2021
@Jarodiv
Copy link
Owner

Jarodiv commented Jul 1, 2021

The issue should be fixed with release v1.1.0

@Jarodiv Jarodiv closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants