Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent/self mixup #10

Closed
Scratchcat1 opened this issue Dec 18, 2017 · 2 comments
Closed

Agent/self mixup #10

Scratchcat1 opened this issue Dec 18, 2017 · 2 comments

Comments

@Scratchcat1
Copy link
Contributor

https://github.com/jaara/AI-blog/blob/361e8c79dcec861e30418f82de17b644028d8623/CartPole-basic.py#L112-L113
If I am not mistaken this should not be agent but self as agent is the variable created outside of class Agent. Therefore the program will work as intended, however this would be better as self.
@jaromiru
Copy link
Owner

Obviously, you’re right. I can correct that in future.

@Scratchcat1
Copy link
Contributor Author

#12
Pull request for corrected version created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaromiru @Scratchcat1