Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3C version missing a GAMMA #17

Open
haowenke opened this issue Jan 18, 2019 · 0 comments
Open

A3C version missing a GAMMA #17

haowenke opened this issue Jan 18, 2019 · 0 comments

Comments

@haowenke
Copy link

haowenke commented Jan 18, 2019 •
edited
Loading

In line 202 of A3C version, R is divided by GAMMA. But in line 211, R is not.
According to your blog:
R_1=(R_0 - r_0+gamma^n * r_n)/gamma
I think line 211 are supposed to be
self.R = self.R - self.memory[0][2]/GAMMA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haowenke