Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma "," appears when parsing from pcap to JSON #40

Closed
normchri opened this issue May 22, 2020 · 3 comments
Closed

Comma "," appears when parsing from pcap to JSON #40

normchri opened this issue May 22, 2020 · 3 comments

Comments

@normchri
Copy link

Hi,
IN a Python3 program, I parse multiple pcap file in JSON using :

for ip in ip_list:
pcap_to_json = pcapkit.extract(fin=(ip+".pcap"), fout=(ip+"out.json"), format='json', extension=False)

Describe the bug
After the first file (10.10.0.51 in annexe) all the JSON files have a "," added at the second line which is not supposed to happen.

Expected behavior
no comma in the second line of JSON files

Additional context
Here is a zip containing examples:
scan_21-05-2020_15-14-13.zip

System information

  • OS Version: Ubuntu 20.04
  • Python Version: 3.8

Thank you for your help !
@normchri normchri changed the title Comma "," appears when parsing from pcap to the JSON Comma "," appears when parsing from pcap to JSON May 22, 2020
JarryShaw added a commit to JarryShaw/DictDumper that referenced this issue May 24, 2020
@JarryShaw
Revised tests for JarryShaw/PyPCAPKit#40
5f8bf4a
@JarryShaw
Copy link
Owner

Hi there, thanks for reporting this issue. But may I know which version of DictDumper and PyPCAPKit you're using?

@normchri
Copy link
Author

Hi,
Here is the version used:
dictdumper 0.7.0.post1
pypcapkit 0.14.5

JarryShaw added a commit that referenced this issue Jun 7, 2020
@JarryShaw
New distribution [0.15.0]
2e21f0a 
 * bumped version to 0.15.0
 * fixed issue #37 & #40 as we updated deps on DictDumper
 * merged protocol parsing & constructing logics
 * revised TCP flow tracing & several interfaces
 * added a full API doc as hosted on https://pypcapkit.jarryshaw.me
 * minor bugfix all over the whole project
@JarryShaw
Copy link
Owner

Issue fixed as we upgrade DictDumper dependency in version 0.15.0

Thx for reporting to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarryShaw @normchri