Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Platform way to Determine Console Size #14

Closed
wants to merge 3 commits into from

Conversation

MinchinWeb
Copy link

Tested on Windows. Now fabulous-demo will run!

@MinchinWeb
Copy link
Author

There, now the tests pass on Travis-CI too!

@jart
Copy link
Owner

jart commented Jul 1, 2021

Thanks for submitting this. I'd rather not introduce upstream dependencies. It might be better if we implement something along the lines of termios in combination with inband probing like \e7\e[9979;9979H\e[6n\e8 → \e[𝑦;𝑥R

@jart jart closed this Jul 1, 2021
@MinchinWeb
Copy link
Author

@jart Are you still supporting Python 2.7 and 3.2?

Starting with Python 3.3, the required function was added to the standard library, and thus does not require any upstream dependency...

@jart
Copy link
Owner

jart commented Jul 2, 2021

I'm happy to bump up to Python 3.3 but I definitely want to keep supporting Python 2.7. Perhaps we could simply keep doing what we're doing for 2.7 and have the update apply only to Python 3.3+ users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants