Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable colors on Windows, enable if --colors is used #217

Closed
jarun opened this issue Sep 23, 2017 · 4 comments
Closed

Disable colors on Windows, enable if --colors is used #217

jarun opened this issue Sep 23, 2017 · 4 comments

Comments

@jarun
Copy link
Owner

jarun commented Sep 23, 2017

Windows does not support POSIX colors by default. It works on terminals like ConEmu.

The plan is to disable colors IF the detected platform in Windows (same as --nc effect).
Enable colors only if option --colors is used.

The relevant discussion is here.

@dertuxmalwieder
Copy link
Contributor

I'd still recommend to - at least - check for ConEmu first, e.g. via the env. variables.

@jarun
Copy link
Owner Author

jarun commented Sep 24, 2017

No problem. I have reviewed the change. Please take a look.

@jarun
Copy link
Owner Author

jarun commented Sep 24, 2017

Note: someone might come back someday asking to support another Windows terminal emulator like ConEmu. It would still work for them if ConemuDir is set as an env var.

@dertuxmalwieder
Copy link
Contributor

It should be trivial to support any "working" ConEmu-like thing (like console² - someone should test that... ;-)) or non-cmd shells as long as they come with their own environment variables. I guess the only reason not to just add a whole bunch of supported cases would be the code size.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants