nnn-1.5: error when compiling to musl-based systems

[maxice8]

Trying to compile and cross-compile musl-based systems causes the following error

==> nnn_x86_64-musl_do_build.log
x86_64-linux-musl-gcc -specs=/void-packages/common/environment/configure/gccspecs/hardened-cc1  -fstack-protector-strong -D_FORTIFY_SOURCE=2  -O2 -pipe -mtune=generic   -I/usr/x86_64-linux-musl/usr/include -o nnn nnn.c -specs=/void-packages/common/environment/configure/gccspecs/hardened-ld -Wl,-z,relro -Wl,-z,now -Wl,--as-needed     -L/usr/x86_64-linux-musl/usr/lib -lreadline -lncursesw
nnn.c:203:2: error: unknown type name ‘ushort’
  ushort filtermode : 1;  /* Set to enter filter mode */
  ^~~~~~
nnn.c:204:2: error: unknown type name ‘ushort’
  ushort mtimeorder : 1;  /* Set to sort by time modified */
  ^~~~~~
nnn.c:205:2: error: unknown type name ‘ushort’
  ushort sizeorder  : 1;  /* Set to sort by file size */
  ^~~~~~
nnn.c:206:2: error: unknown type name ‘ushort’
  ushort blkorder   : 1;  /* Set to sort by blocks used (disk usage) */
  ^~~~~~
nnn.c:207:2: error: unknown type name ‘ushort’
  ushort showhidden : 1;  /* Set to show hidden files */
  ^~~~~~
nnn.c:208:2: error: unknown type name ‘ushort’
  ushort showdetail : 1;  /* Clear to show fewer file info */
  ^~~~~~
nnn.c:209:2: error: unknown type name ‘ushort’
  ushort showcolor  : 1;  /* Set to show dirs in blue */
  ^~~~~~
nnn.c:210:2: error: unknown type name ‘ushort’
  ushort dircolor   : 1;  /* Current status of dir color */
  ^~~~~~
nnn.c:211:2: error: unknown type name ‘ushort’
  ushort metaviewer : 1;  /* Index of metadata viewer in utils[] */
  ^~~~~~
nnn.c:212:2: error: unknown type name ‘ushort’
  ushort color      : 3;  /* Color code for directories */
  ^~~~~~
make: *** [Makefile:26: nnn] Error 1

adding #include <sys/types.h> to nnn.c seems to fix the problem with ushort and compilation ( and cross-compilation ) works correctly

[jarun]

Please raise the PR.

Also, are you stuck on a release because of this? I that case I can do a minor release for you this afternoon. Otherwise, it will be in master till the next release.

Thanks for reporting it!

[maxice8]

Please raise the PR.

sorry but my "quick solution ( read hackish solution)" was simply adding #include <sys/types.h> to the top which i have no clue if it breaks any of the other platforms supported ( The *BSDs and OSX )

Also, are you stuck on a release because of this? I that case I can do a minor release for you this afternoon. Otherwise, it will be in master till the next release.

It can certainly be patched to build but it's much preferred to follow upstream, if upstream releases a fix ( either as a commit that can be picked as a patch or a minor release that can be bumped to ) all the better.

Thanks for reporting it!

Thanks for attention

[jarun]

i have no clue if it breaks any of the other platforms supported

Travis CI takes care of this for nnn.

Also,
are you stuck on a release because of this?

[maxice8]

are you stuck on a release because of this?

No

[maxice8]

Sent a PR to try to fix.

[jarun]

@maxice8 musl-libc compilation is now integrated on Travis CI.

[maxice8]

On Thu, Mar 15, 2018 at 10:49:39PM +0000, Arun Prakash Jana wrote: @maxice8 musl-libc compilation is now integrated on Travis CI. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.*

sweet, should make my Void Linux and Alpine's life easier.