-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell invocation results in a segfault on OpenBSD #49
Comments
More debugging info:
|
I guess the answer is |
First, thanks a lot for testing nnn out and for the issues and PRs! I will review and pull them in a few hours. Regarding the issue: It can be optional but it's quite helpful. So I'm thinking how about checking the shell and if it's bash, fish or mksh show this msg? is there any alternative on ksh? |
Resolved at d835f72. |
Well, let's pave a bright future for nnn :) there are many shells right now, and there will probably more in 2052, all w/ or w/o support with this special variable. So I think it's cleaner to rely on this variable existence and use it if it's there rather than add/remove support shells based on their names every time 1) new shell with a new name is developed; 2) support for this variable is added/removed. So we'd actually need to track it or rely on users' reports. On the other hand, there we just check the var and use it if it's available -- cheap and simple. |
Makes sense, the reason I already accepted the PR. ;) |
When shell invocation (
!
) is performed, nnn crashes while spawning and gets back to its primary UI.The text was updated successfully, but these errors were encountered: