-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Review: Documentation #1
Comments
These all sound sensible points. I'll see what I can do. Thanks. |
OK, I've had an initial go at this: I'll proof-read & integrate some plots the next time I can make the time. |
Thanks @jarvist. The doc is much improved. For the examples, could you please add reference(s) for the parameters used in your calculation? For example, in your first example for CdTe, it says:
Please add a reference or two from which these parameters were obtained, maybe a volume of Landolt-Börnstein. |
Thanks @jarvist. The documentation is much improved! Here are some small problems to fix InstallationPlease replace "git://" with "https://". The former fails if there is firewall. It is safer to assume https works for most people. Examples
|
Hello everyone - hopefully with this last commit (e4ac60d), all of the issues above should have been solved! Longer term the package could definitely do with some restructing, breaking down of the fairly monolithic functions, and a complete writing of the |
@jarvist 👍 with the improvements of documentation on usage and the plots. The instructions on plotting using PlotPolaron still does not work for me, but the alternative (gnuplot) works. I feel the part on using PlotPolaron can be made smoother for users. But I am not an expert in Julia, and don't know enough to comment. @lheagy please decide if you want to ask an Julia expert to review or leave it as is. In the latter case, I would suggest @jarvist to make the gnuplot instruction more complete, but it is not required for closing this issue. |
I also could not get PlotPolaron working with the provided instructions. I think that there is a discrepancy here if you install using I do think that plotting is an important part of usability, so I think this is worth sorting out, or at a minimum, expanding the examples to give the user more instructions on using gnuplot as a part of the workflow. |
OK. That all makes sense. I'll try and fix the plotting one-way or another. |
Hello all! @Kevin-Mattheus-Moerman pointed me to your discussion here, and I'm happy to offer any advice re: plotting that I can. This is what I had to do to get your plots to run: julia> using PolaronMobility, Plots
julia> gr()
julia> include(Pkg.dir("PolaronMobility","src","PlotPolaron.jl"))
julia> using PlotPolaron
julia> ... # Do your polaronmobility calculations
julia> plotpolaron(...) This will work if you have installed Also when I try to plot the example
I get an error in the radius vs temperature plot because @jarvist if you want some help converting |
Thanks for that @wkearn . I've added your instructions to the documentation, and fixed (by commenting out) the obsolete attempt to plot rfsmallalpha. Hopefully we should be good to go I think! |
👋 Hi @yxqd, would you be willing to take another look at this? |
Thanks @lheagy for the reminder. Using Juliabox is a nice idea. But I encountered this problem: And I cannot test the plotting in juliabox either since the calculations failed at cell 4. I will test plotting from command line soon. |
How frustrating! (...After a bit of investigation...) This is because JuliaBox is still on As a work around, you can add 'Optim' to the 'Yours' list in the 'Packages' menu on the root of JuliaBox. It takes a while to build the package; and then a while to compile after you restart your kernel. This appears to pull in a fresh stable copy. |
Thanks. I tried the command line interface locally, and it does work now after The notebook at JuliaBox mostly works now after adding Optim to "registered" packages of JuliaBox. Maybe you want to add this somewhere in your documentation too. There is still one last error with the JuliaBox notebook: Please check. |
@yxqd OK Jiao, I've pushed a new version of the ipython notebook without the 'integer division' error (the approximation is no longer calculated as standard). I've also introduced some text to I think this should be sufficient to cover the final checkbox above - "Example usage". |
Just tried it. It seems working now. @lheagy could you please close this ticket? |
This looks great @jarvist! |
I think there are a number of steps that can be taken in the documentation to help users get up and running more easily. This is connected to the JOSS review at openjournals/joss-reviews#566
@yxqd may also have some suggestions here.
The text was updated successfully, but these errors were encountered: