Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about JS comparison operators #2846

Closed
jgonggrijp opened this issue May 6, 2020 · 1 comment
Closed

Add a note about JS comparison operators #2846

jgonggrijp opened this issue May 6, 2020 · 1 comment

Comments

@jgonggrijp
Copy link
Collaborator

I would like to close all three of these tickets, because I believe they are based on a misunderstanding of the < operator, and I'd like to address this with a note in the documentation instead:

The note would be somewhere at the bottom of the page, with a link to the MDN entry on the comparison operators. Reference entries on functions like _.sortBy and _.sortedIndex would reference to this note.

@jashkenas do you agree?

@jashkenas
Copy link
Owner

I agree! I don’t think that sorting NaN or undefined are an important problem to "fix" — you should never be sorting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants