Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation _.unescape uses wrong hex code #2925

Closed
MalteSaup opened this issue Apr 26, 2021 · 4 comments · Fixed by #2934
Closed

Documentation _.unescape uses wrong hex code #2925

MalteSaup opened this issue Apr 26, 2021 · 4 comments · Fixed by #2934
Assignees
Labels
documentation starter good choice for new contributors

Comments

@MalteSaup
Copy link

MalteSaup commented Apr 26, 2021

In the documentation you use &#96 ; for the ` Symbol, wich is the correct Decimal Code, but _.unescape seems to only work with the hex code &#x60 ; wich also is returned from the _.escape function

@jgonggrijp
Copy link
Collaborator

Thanks for bringing this to our attention, @MalteSaup! If you like, please feel welcome to submit a PR to fix the documentation and get the credit for it.

@jgonggrijp jgonggrijp added documentation starter good choice for new contributors labels Apr 26, 2021
@itsdeekay
Copy link

Hi @jgonggrijp , I have started contributing to open source. Could you assign this issue to me so that I can contribute?

@jgonggrijp
Copy link
Collaborator

@itsdeekay Thanks for stepping up! You can contribute without being assigned, but I don't mind assigning people so there you are.

@itsdeekay
Copy link

itsdeekay commented Jul 8, 2021

Thanks @jgonggrijp , I have created a pull request for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation starter good choice for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants