New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running without webdriver.executeScript() #52
Comments
I'm not opposed, particularly since the There is one major caveat though: None of the platforms you mention are supported, and that's not going to change. It can't change, because I don't have any way to test Jasmine on those devices. So there's always a possibility that a future change to jasmine-core or jasmine-browser-runner could break compatibility with those environments, and it would only be restored if you submitted a PR to fix it. But I imagine you'd have that problem no matter what testing tools you choose. |
That makes sense. We're already in that boat in general with Karma+Jasmine, and it doesn't concern me. I wouldn't require you to officially support any of our weird platforms. I think in general, package-lock.json will prevent us from getting broken by surprise, and if we found issues during an upgrade, we would be more than willing to contribute fixes. |
This might not be the best successor to Karma for us, based on conversation in #51. So we will drop this issue and continue the search elsewhere. Thanks for your time! |
In our test lab, we have partial WebDriver implementations for some consumer electronics devices (TVs, Xbox, etc) that do not support executeScript().
With Karma, we didn't need executeScript(). Communication from the jasmine environment back to the runner was done through a WebSocket.
I would like to explore removing the getBatch() function in lib/runner.js, which is based on executeScript(). This will allow us to use jasmine-browser-runner on all our lab devices. I believe we could open a web socket back to jasmine-browser-runner's express-based web server for reporting, instead of dumping batches of events with executeScript().
The text was updated successfully, but these errors were encountered: