Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the animation speed #544

Open
grahamthesmith opened this issue Apr 24, 2017 · 2 comments
Open

Changing the animation speed #544

grahamthesmith opened this issue Apr 24, 2017 · 2 comments
Assignees

Comments

@grahamthesmith
Copy link

I have started using the off canvas push menu as demonstrated on your site, and it is working great.
I am struggling however to get it to work with a slower animation.
The css file has transition speed in the .canvas-sliding class, but modifying that is not enough.
I have additionally tried to amend the js file by increasing the duration in the .animate method, but I end up with a jerky animation (starts at the right speed but then jumps to the open / closed position, depending on whether I am opening of closing the menu).
It would be great if the speed could be added as an option in future, but for now any advice on what I can do to "fudge" the speed in the meantime would be appreciated.

@poratuk poratuk self-assigned this May 17, 2017
@poratuk
Copy link
Collaborator

poratuk commented May 17, 2017

I added animation speed on the options to the Offcanvas in PR #547

@grahamthesmith
Copy link
Author

Great thank you.
Note that the CSS also needs to be changed to match whatever value is used in the new option though, so for example I set animateSpeed to 1000 and also:

.canvas-sliding {
  -webkit-transition: top 1s, left 1s, bottom 1s, right 1s;
          transition: top 1s, left 1s, bottom 1s, right 1s;
}

Its a shame that the CSS cannot also be modified by the new option ... or could it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants