Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the need for GITHUB_TOKEN in the environment #2

Closed
jason-c-daniels opened this issue Aug 2, 2022 · 0 comments · Fixed by #23
Closed

Eliminate the need for GITHUB_TOKEN in the environment #2

jason-c-daniels opened this issue Aug 2, 2022 · 0 comments · Fixed by #23

Comments

@jason-c-daniels
Copy link
Owner

Problem
Storing a GitHub token in the environment is somewhat risky, no matter how short lived.

Possible resolution
Perhaps provide a flag that indicates if gh auth login or gh auth login --with-token < some-token-file.txt can be used to help people better secure their GitHub secrets.

Workaround considered:
A secrets manager wrapper that only sets the environment for the course of that run.
I've not found any (yet) that run in git-bash. Even with this workaround, there's a chance that the process could get compromised exposing the secret. Albeit the window of opportunity is much lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant