Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use CDN link or make a separate folder for images #1634

Closed
priyankarpal opened this issue Sep 25, 2023 · 8 comments
Closed

refactor: use CDN link or make a separate folder for images #1634

priyankarpal opened this issue Sep 25, 2023 · 8 comments

Comments

@priyankarpal
Copy link
Contributor

Try to use the CDN link for images or make a separate folder for images. This will help to follow a clear project structure. Please tell me @JasonDsouza212 what should we use. CDN or separate image folder

  • We are using images directly on the assets folder that's not a good practice.

image

@github-actions
Copy link

Congratulations, @priyankarpal! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@JasonDsouza212
Copy link
Owner

what service are you planning on using to store images?

@priyankarpal
Copy link
Contributor Author

what service are you planning on using to store images?

I will use github cdn

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open for few days with no activity. It will be closed in next 1 days if no further activity occurs.

@priyankarpal
Copy link
Contributor Author

@JasonDsouza212 you can assign someone

@priyankarpal priyankarpal removed their assignment Oct 17, 2023
@JasonDsouza212
Copy link
Owner

@priyankarpal sure

Copy link

github-actions bot commented Nov 3, 2023

This issue has been automatically marked as stale because it has been open for few days with no activity. It will be closed in next 1 days if no further activity occurs.

Copy link

This issue has been closed because it has not received any activity in the last few days since being marked as 'stale'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants