Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute "placement" is actualy required in GuideType #16

Open
Kreozot opened this issue Oct 13, 2020 · 2 comments
Open

Attribute "placement" is actualy required in GuideType #16

Kreozot opened this issue Oct 13, 2020 · 2 comments

Comments

@Kreozot
Copy link
Contributor

Kreozot commented Oct 13, 2020

Regardless of documentation, attribute "placement" is actualy required in GuideType (ContextWrapper.tsx). So, TypeScript is highlighting the example from readme as an error.
@jasongaare
Copy link
Owner

Would you be able to open a PR to correct this?

@Kreozot
Copy link
Contributor Author

Kreozot commented Oct 18, 2020

Yeah, sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kreozot @jasongaare