Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n implementation to support param matches (e.g. [[lang=lang]]) #22

Open
jasongitmail opened this issue Dec 20, 2023 · 2 comments
Labels

Comments

@jasongitmail
Copy link
Owner

jasongitmail commented Dec 20, 2023

Currently, only exactly [[lang]] is supported.

See: #3 (comment)

@buhodev
Copy link

buhodev commented Jan 24, 2024

I think this is not needed anymore. Haven't migrated yet so idk if it'll work out of the box with super-sitemap, but take a look at https://inlang.com/m/dxnzrydw/library-inlang-paraglideJsAdapterSvelteKit

TL;DR: now a [[lang=lang]] route is not required (thanks to the paraglide preprocessor and https://kit.svelte.dev/docs/hooks#universal-hooks-reroute)

@jasongitmail
Copy link
Owner Author

jasongitmail commented Jan 25, 2024

It won't work out of the box unfortunately bc super sitemap depends on reading the routes from disk and parsing them.

Paraglide adds a couple curve balls: 1) lack of lang route param to identify these and 2) localizable routes where the route text itself changes, and not just the lang slug. It might require changing literally everything, idk.

If someone wants to look into paraglide and open an issue proposing how we can adapt the current SuperSitemap to support it technically, that'd be helpful.

Otherwise, I'll have to look into it to gauge feasibility a few weeks down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants