Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in roll_max with vectors of lenth around 545 #32

Closed
lukasz-bednarz-reddeersystems opened this issue Jul 1, 2020 · 4 comments
Closed
Labels

Comments

@lukasz-bednarz-reddeersystems
Copy link

lukasz-bednarz-reddeersystems commented Jul 1, 2020

roll::roll_max(rep(1,545), 10)

causes crash in R-4.0.2 with roll v1.1.4

@jasonjfoster
Copy link
Owner

Thanks for the reprex. I have fixed the issue in the development version:

# install.packages("devtools")
devtools::install_github("jjf234/roll")

@lukasz-bednarz-reddeersystems
Copy link
Author

Hi,

When do you think the CRAN version with fix might be available?

@jasonjfoster
Copy link
Owner

I would like to update the CRAN version in the next week or two. Could you confirm the fix resolves the issue?

@lukasz-bednarz-reddeersystems
Copy link
Author

Yes, the fix is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants