Replace isomorphic-fetch with node-fetch

[schickling]

Given problems as describe in #14 it probably makes sense to replace isomorphic-fetch with node-fetch.

Let's keep this up for discussion for a while to collect feedback/hear objections.

[lquixada]

@schickling, I don't recommend using node-fetch. Although it works with some browsers, it doesn't on those who doesn't support window.fetch natively such as IE11-. One possible candidate would be whatwg-fetch but it's not suitable for node environments.

isomorphic-fetch found a way to get the best of both worlds but it came with a flaw: a bug that stops it from working on React-Native enviroments, issue 125, also mentioned on #14. The problem is that repo is not maintained anymore. So we're orphans here.

Probably a lesser known project like fetch-everywhere would do the trick or you can roll out your own!

[schickling]

Thanks a lot. This is great input!

[mysport12]

First off, thank you for this package. It has helped me out tremendously. As for this discussion, I have been having success using fetch-everywhere.

[lquixada]

We have issues with a lot of fetch alternatives in the community. For instance, isomorphic-fetch has this bug, is no longer maintained and is outdated. fetch-everywhere is in the same situation but with the bug fixed. In both of them polyfill is mandatory. This can be an issue sometimes.

That's why I created cross-fetch. We have this project for a huge e-commerce company here that the same javascript codebase needed to run on several platforms (react-native included). No lib felt right for this job. But now we use cross-fetch: it's fixed, updated and cross-platform.

[schickling]

Thanks a lot for your comment @lquixada. I'm excited to see your project and hope it stays well-maintained and up-to-date (I know how hard this can be!)

Also, thanks a lot for the PR. Looking forward to see whether this also fixes #18. 💪

[lquixada]

Thanks for accepting my PR! I'm so excited! I'll finally be able to move my graphql migration foward! 🎉