Is "custom fetch" still possible?

[anulman]

I was reviewing the source to see if I could use the "custom fetch" feature to somehow wrap Shopify's Admin GraphQL API with graphql-request, and noticed that the fetch param seems to be ignored vs. the created fetcher, below.

graphql-request/src/index.ts

Lines 394 to 410 in 38fda1d

	const makeRequest = async <T = unknown, V extends Variables = Variables>(params: {
	url: string
	query: string | string[]
	variables?: V
	headers?: Dom.RequestInit['headers']
	operationName?: string
	fetch: Fetch
	method?: HTTPMethodInput
	fetchOptions: Dom.RequestInit
	middleware?: RequestMiddleware<V>
	}): Promise<Response<T>> => {
	const { query, variables, fetchOptions } = params
	const fetcher = createHttpMethodFetcher(uppercase(params.method ?? `post`))
	const isBatchingQuery = Array.isArray(params.query)
	const response = await fetcher(params)
	const result = await getResult(response, fetchOptions.jsonSerializer ?? defaultJsonSerializer)

I'm guessing L406 should be something like const fetcher = params.fetch ?? createHttpMethodFetcher(...);

[doronkopit5]

@anulman you can see here that in the end it uses the fetch param

[anulman]

you’re right! i ended up using it and had no issues; forgot to come back and close this. thank you, and sorry for the false alarm 😅