Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Please start using Semantic Versioning #162

Closed
KateGo520 opened this issue Aug 1, 2020 · 4 comments
Closed

Proposal: Please start using Semantic Versioning #162

KateGo520 opened this issue Aug 1, 2020 · 4 comments

Comments

@KateGo520
Copy link

I found that this project already supports Go modules. But sadly, the tags doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it.

	github.com/jasonlvhit/gocron v0.0.0-20200423141508-ab84337f7963

Else the mod file shows something like github.com/jasonlvhit/gocron v0.0.0-20200423141508-ab84337f7963 which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control

So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc.

@KateGo520
Copy link
Author

@Streppel @arjunmahishi Could you help me review this issue? Thx :p

@Streppel
Copy link
Collaborator

Streppel commented Aug 1, 2020

Hi @KateGo520! Absolutely, we can fix this here. Be aware, though, that we migrated to a new repo linked in the readme and we are working collectively over there, be sure to check it out!

@Streppel
Copy link
Collaborator

Streppel commented Aug 2, 2020

Updated semver :-)

@Streppel Streppel closed this as completed Aug 2, 2020
@KateGo520
Copy link
Author

@Streppel OK, I see the new link. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants