Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-configurable markup sequence #32

Closed
albell opened this issue Mar 11, 2015 · 1 comment
Closed

User-configurable markup sequence #32

albell opened this issue Mar 11, 2015 · 1 comment

Comments

@albell
Copy link

albell commented Mar 11, 2015

One other thing: I'd like to be able to specify markup order of the various elements. I imagine I'm not the only one. Different ways to do this, but the API could look something like this.

twitterFetcher.fetch( {
  "domId": 'example-with-custom-sequence',
  "maxTweets": 5,
  "enableLinks": true,
  "markupSequence": [
    "time-posted",
    "user",
    "interact"  
  ]
});

(I am happy to help if this is something you're interested in. I think there could be some major interest/exposure in this because it's so much easier than the alternative.)

@jasonmayes
Copy link
Owner

That seems cool. If you can make a PR for that I can take a look at code. Please note the browsers we need to support for any new code written :-) Also this should be optional, so if not specified the default order is preserved for everyone who is already using TwitterFetcher without this parameter. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants