New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular Dependency Detection #1

Open

jasonmcaffee opened this issue Nov 26, 2013 · 0 comments

Owner

jasonmcaffee commented Nov 26, 2013

lib/modulus.js _recursivelyFindDependencies needs detection for circular dependencies.

What I would like is logic to detect that there is a circular dependency, and break out of recursion when it's detected.

e.g. moduleA depends on moduleB which depends on moduleC which depends on moduleA.

I haven't run into an issue with circular deps before, but I think it's a valid issue. http://stackoverflow.com/questions/4881059/how-to-handle-circular-dependencies-with-requirejs-amd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment