Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.6+ Support #19

Closed
aaronfischer opened this issue Jan 25, 2019 · 1 comment · Fixed by #23
Closed

Ember 3.6+ Support #19

aaronfischer opened this issue Jan 25, 2019 · 1 comment · Fixed by #23

Comments

@aaronfischer
Copy link

aaronfischer commented Jan 25, 2019

Hello!
Are there any current plans to get this upgraded to 3.6+? With the eventual deprecation of willTransition and didTransition. I may try taking a look at this when I get a chance. Hopefully just moving this into the init() and going off the new router events. https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_transition-state

@blimmer
Copy link
Collaborator

blimmer commented Jan 25, 2019

Hey @aaronfischer - thanks for reaching out. I'm not working in Ember that much these days so this isn't on my radar at the moment. If you're willing to open a PR, that'd be great!

Looking at the link, it looks like they're going to keep these hooks until 4.0.0+, so we probably have some time and you'll want to make sure you don't break existing folks in the upgrade.

screen shot 2019-01-25 at 16 20 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants