Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align default JsonSerializerOptions with defaults of SystemTextJsonOutputFormatter #49

Closed
jasonmitchell opened this issue Feb 24, 2021 · 1 comment · Fixed by #66
Closed

Align default JsonSerializerOptions with defaults of SystemTextJsonOutputFormatter #49

jasonmitchell opened this issue Feb 24, 2021 · 1 comment · Fixed by #66
Milestone
v3

Comments

@jasonmitchell
Copy link
Owner

Currently if no JsonSerializerOptions are passed when instantiating HalJsonOutputFormatter, a new instance is created with mostly default settings. The defaults should align with the defaults for SystemTextJsonOutputFormatter to avoid surprises when switching between application\json and application\hal+json.

In particular, the defaults for SystemTextJsonOutputFormatter will use a camel case naming policy while HalJsonOutputFormatter does not. The screenshot below shows the defaults for SystemTextJsonOutputFormatter.

Screenshot 2021-02-24 at 21 11 25
@jasonmitchell
Copy link
Owner Author

Is switching to camel case property naming a breaking change? If the client were a javascript application then this change could cause breakages.

This was referenced Feb 24, 2021
Merged
Closed
@jasonmitchell jasonmitchell added this to the v3 milestone Mar 2, 2021
@jasonmitchell jasonmitchell mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

Align default JsonSerializerOptions with ASP.NET defaults jasonmitchell/hallo
1 participant
@jasonmitchell