Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rendering of "0" values #1

Closed
wants to merge 2 commits into from
Closed

Conversation

holic
Copy link

@holic holic commented Aug 14, 2012

{{=age}} with { age: 0 } will render "0"
{{=name}} with { name: false } will render "false"
{{=name}} with { name: null } or {} will render ""

@holic
Copy link
Author

holic commented Aug 14, 2012

Hmm...didn't mean to have the second commit included in this pull request. Thoughts on adding support for functions in 40c4dc0?

@jasonmoo
Copy link
Owner

Hey thanks for the contribution. I decided to take a slightly different tack. Making zero printable but keeping false and null as empty values. I think it makes a bit more sense. (6418d7e)

I think the functions are better handled by the logic generating/rendering the templates than embedded in the supplied params. This seems like another possible point of injection.

@jasonmoo jasonmoo closed this Aug 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants