Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"getEditorState" is not a function (newer draft-js and draft-js-plugins-editor versions) #13

Open
djackson1 opened this issue Nov 11, 2020 · 1 comment

Comments

@djackson1
Copy link

Hey @jasonphillips, not sure if you're still around or open to working on this.

I've been using draft-js, draft-js-plugins-editor and draft-js-richbuttons-plugin for some time in my personal project and had recently decided to upgrade some versions, notably:

draft-js version from 0.10.x to 0.11.x. and also
draft-js-plugins-editor to 3.0.0 (or even 2.2.x)

My issue is that the function signature for handleKeyCommand has changed and now requires a "dummy arg" (I've tested this locally and it seems to allow the plugin to continue working)

Would I be able to make a PR to make this work on newer draft-js/plugins-editor versions?

Thanks

@emilia-friedberg
Copy link

I made a PR to this effect here: #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants