Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request & Porting to py3 #9

Closed
anoduck opened this issue Sep 9, 2022 · 2 comments
Closed

Feature Request & Porting to py3 #9

anoduck opened this issue Sep 9, 2022 · 2 comments

Comments

@anoduck
Copy link

anoduck commented Sep 9, 2022

This is a very handy script to have around. Does a good job of simply generating json data to timeline svg images.

Desperately needs to be officially ported to python3. At least two out of the five pull requests are available to accomplish this.

If I can find the time, a few extra features could be added to make working with this script much easier.

  • dynamically determined sizes based on defined width.
  • incorporation of argparse.
  • etc, etc...
@mrchess
Copy link

mrchess commented Mar 18, 2023

I just found this library too and needed to use it with py3.

The adjustments I had to make was:

  1. update tkinter imports https://github.com/jasonreisman/Timeline/blob/master/make_timeline.py#L10-L11
import tkinter.font as tkFont
import tkinter
  1. remove utf-8 encoding from last line https://github.com/jasonreisman/Timeline/blob/master/make_timeline.py#L255
print(timeline.to_string())

Then it ran for me!

@anoduck
Copy link
Author

anoduck commented Mar 20, 2023

@mrchess I made similar changes as well, but for my purposes the print was much too tiny to use. So, a little more tinkering was needed to enlarge the print for use. Those modifications were extremely easy, which makes me wonder why the creator has not made them himself by now.

@anoduck anoduck closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants