Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for horizontal lazy load in overflow contianer #130

Merged
merged 3 commits into from
Jun 30, 2019

Conversation

StoraH
Copy link
Contributor

@StoraH StoraH commented Oct 24, 2017

This in a starting point to support horizontal lazy load
Still some work needs to be done before it can be merge
Todo:

  • width prop with same functionality as height
  • support for window horizontal scroll as well

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.904% when pulling c4f6ba3 on StoraH:master into d4fde73 on jasonslyvia:master.

@jasonslyvia
Copy link
Collaborator

hi @StoraH , thanks for your contribution, though I'm really considering using InstersectionObserver in replace of current implementation, because it saves us a bunch of options (height, overflow and more).
See #129 for more information if you're interested.

@nianiaJR
Copy link

will consider to merge this pr? @ameerthehacker

@ameerthehacker
Copy link
Collaborator

@nianiaJR before merging this PR I would like to confirm with @StoraH that he has completed the todo and is there anything more to be added to this PR?

@nianiaJR
Copy link

@ameerthehacker Ok, I'll use the fork one before you finish this,thanks your reply.

@ameerthehacker ameerthehacker merged commit 4e83a11 into twobin:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants