Support non-nodejs environments #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, not thought of that, thanks for contribution! |
|
Are you expecting an immediate release? |
|
Hello! Thanks for merging this so fast! As for an immediate release, that would be welcome - although I might have another contribution coming in with |
|
I'd love to. |
|
Er actually, the other bug I was looking into turned out to be a problem with our usage of this library - not a bug in it. In other words, a new release of this would be mighty appreciated so we can start using this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! We've been using react-lazyload at our company for making React components lazyload both in a nodeJS and not in a nodeJS environment, and the latter one doesn't work because of the assumption that
processis a defined variable. This PR just puts in a check to make sure the variable exists before accessing it and is pretty harmless.